feat: Update readme #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapstromegon
suggested changes
Jun 12, 2025
There was a problem hiding this comment.
I didn't repeat comments all over the place.
We should probably consider splitting README.md and the crate entry docs.
Also we should add a section on compatibility with the cloudevents-sdk crate.
Right now the code in the examples feels very "go-like" and I added some comments on how to make them more "rusty".
|
In general I like this PR, only one philosophical feedback on examples because I'd expect examples to be easily executable to see it works. |
goloroden
requested changes
Jul 14, 2025
goloroden
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.